Add observability to Bedrock Titan Embedding model #3014
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSriVarshan
force-pushed
the
add-observability-to-bedrock-titan
branch
from
0ff770f to
95ba402
Compare
|
Thanks. A few things to clean up in the PR.
adding and changing the bean def to be Also, you can use |
PSriVarshan
force-pushed
the
add-observability-to-bedrock-titan
branch
3 times, most recently
from
0cd6a52 to
ed41e60
Compare
Signed-off-by: PSriVarshan <[email protected]>
Signed-off-by: PSriVarshan <[email protected]>
Signed-off-by: PSriVarshan <[email protected]>
Signed-off-by: PSriVarshan <[email protected]>
Signed-off-by: PSriVarshan <[email protected]>
Signed-off-by: PSriVarshan <[email protected]>
PSriVarshan
force-pushed
the
add-observability-to-bedrock-titan
branch
from
ed41e60 to
b127661
Compare
|
I think now the branch is fully ready and optimal. Thanks a ton for the guidance @markpollack. Waiting for your further guidance. |
|
@PSriVarshan Thanks for the PR and following up with the changes. |
| <dependency> | ||
| <groupId>io.micrometer</groupId> | ||
| <artifactId>micrometer-observation</artifactId> | ||
| <version>1.15.0-RC1</version> |
There was a problem hiding this comment.
We don't need an explicit version here.
| return new TitanEmbeddingBedrockApi(properties.getModel(), credentialsProvider, regionProvider.getRegion(), | ||
| objectMapper, awsProperties.getTimeout()); | ||
| } | ||
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean |
There was a problem hiding this comment.
Similar to other auto configurations, we don't provide the default ObservationRegistry instead provide NOOP registry when none provided. Will update the PR when merging.
|
Squashed, addressed the review comments and pushed the changes via a36c709 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces observability to the Bedrock Titan Embedding Model by adding Micrometer
Observationaround the embedding API call. This ensures consistent metrics and tracing support in accordance with the Spring AI observability pattern.ObservationRegistry.model,input_type, andinput_length.Changes
BedrockTitanEmbeddingModel.javato wrap the API call inObservation.createNotStarted().observe(...)Related Issue
Fixes #2983
Checklist
ObservationRegistryDo let me know if there are any further modifications required within the PR